.github/workflows/build-nightly_13.yml (1)

36-36: Deprecated bash arithmetic syntax in commented code.

The $[...] syntax is deprecated in modern bash. When this code is uncommented, consider using $((...)) instead for arithmetic expansion.

-#          timespan=$[now - commit]
+#          timespan=$((now - commit))

Note: The same deprecated syntax exists in build-nightly_12.3.yml at line 35 and could be fixed there as well.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/build-nightly_13.yml at line 36, The commented arithmetic
assignment timespan=$[now - commit] uses deprecated $[...] syntax; update the
comment to use POSIX-friendly arithmetic expansion by replacing the deprecated
form with $((now - commit)) wherever it appears (including the similar
occurrence in build-nightly_12.3.yml) so that when uncommented it will work in
modern bash.

.github/workflows/build-nightly_v13.yml (1)

11-20: Consider using an environment variable for safer shell interpolation.

While the current implementation works correctly, directly interpolating ${{ github.ref_name }} into the shell script could be fragile if branch names ever contain special characters. Using an environment variable is a more robust pattern.

♻️ Suggested improvement

 jobs:
   check-branch:
     runs-on: ubuntu-latest
     steps:
     - name: Validate source branch
+      env:
+        BRANCH_NAME: ${{ github.ref_name }}
       run: |
-        if [ "${{ github.ref_name }}" != "V13" ]; then
+        if [ "$BRANCH_NAME" != "V13" ]; then
           echo "::error::Please call the workflow from the V13 branch"
           exit 1
         fi

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/build-nightly_v13.yml around lines 11 - 20, The step
"Validate source branch" in job check-branch currently interpolates ${{
github.ref_name }} directly into the shell; instead set an environment variable
(e.g., REF_NAME) from ${{ github.ref_name }} at the job or step level and
reference that in the run script using a quoted shell variable ("$REF_NAME") to
avoid word-splitting or special-character issues; update the run block in the
"Validate source branch" step to use the env var and ensure comparisons use the
quoted variable.